Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5343: Introduce RunCoverageForTestTarget and CoverageRunner utilities to run code coverage for a specific bazel test target [Blocked: #4886]. #5420

Conversation

Rd4dev
Copy link
Collaborator

@Rd4dev Rd4dev commented Jun 4, 2024

Explanation

[WIP]

Fixes part of #5343

  • This PR Introduces RunCoverageForTestTarget and CoverageRunner script utilities to run code coverage for a specific bazel test target.
  • Originally the RunCoverageForTestTarget was planned to be RunCoverage, but now since the new approach is to use filenames primarily for the script execution which will need introduction of another script (probably named as RunCoverage for simplicity) to avoid conflicts I renamed this to RunCoverageForTestTarget.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Rd4dev Rd4dev requested review from a team as code owners June 4, 2024 07:36
@Rd4dev Rd4dev requested review from BenHenning and removed request for a team June 4, 2024 07:36
@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Jun 4, 2024

@adhiamboperes, before I proceed, could you please confirm if the chaining of the PRs is done right?

@Rd4dev Rd4dev changed the title Fix part of #5343: Introduce RunCoverageForTestTarget and CoverageRunner utilities to run code coverage for a specific bazel test target. Fix part of #5343: Introduce RunCoverageForTestTarget and CoverageRunner utilities to run code coverage for a specific bazel test target [Blocked: #4886]. Jun 4, 2024
Copy link

oppiabot bot commented Jun 12, 2024

Hi @Rd4dev, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 12, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 13, 2024
@BenHenning BenHenning deleted the branch oppia:migrate-to-newer-bazel-and-kotlin June 13, 2024 06:08
@BenHenning BenHenning closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants